Skip to content

ui(locales): remove duplicates and fix typos #11872

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

ui(locales): remove duplicates and fix typos #11872

wants to merge 1 commit into from

Conversation

@jbampton
Copy link
Member

Description

This PR mainly fixes spelling and standardizes locale files

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • Build/CI
  • Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@codecov
Copy link

codecov bot commented Oct 20, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 17.56%. Comparing base (8bbe253) to head (9d07305).

Additional details and impacted files 
@@            Coverage Diff            @@
##               main   #11872   +/-   ##
=========================================
  Coverage     17.56%   17.56%           
- Complexity    15532    15533    +1     
=========================================
  Files          5909     5909           
  Lines        529012   529012           
  Branches      64604    64604           
=========================================
+ Hits          92913    92914    +1     
+ Misses       425652   425651    -1     
  Partials      10447    10447
Flag Coverage Δ
uitests 3.58% <ø> (ø)
unittests 18.63% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@DaanHoogland
Copy link
Contributor

@jbampton , I am abusing you PR to test if the GHA failures are gone (by rebasing) hope you don’t mind.

@DaanHoogland DaanHoogland force-pushed the ui-json-typos-and-duplicates branch from 02738c4 to 9d07305 Compare October 22, 2025 10:51
@DaanHoogland
Copy link
Contributor

about the contents of the PR; it looks good, but I only see typoes fixed, no duplicates removed. Is that correct @jbampton ?

@jbampton
Copy link
Member Author

about the contents of the PR; it looks good, but I only see typoes fixed, no duplicates removed. Is that correct @jbampton ?

message.success.asign.vm keys were removed whilst not exact duplicates the correct spelling was already there also

@DaanHoogland
Copy link
Contributor

about the contents of the PR; it looks good, but I only see typoes fixed, no duplicates removed. Is that correct @jbampton ?

message.success.asign.vm keys were removed whilst not exact duplicates the correct spelling was already there also

clear, sorry I missed that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DaanHoogland DaanHoogland DaanHoogland approved these changes

Assignees

No one assigned

Labels

component:UI

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jbampton @DaanHoogland